Open jamviking opened 8 years ago
Which sub generator is producing this?
meanjs:crud-module
On Mon, Mar 7, 2016 at 10:51 AM, Cody B. Daig notifications@github.com wrote:
Which sub generator is producing this?
— Reply to this email directly or view it on GitHub https://github.com/meanjs/generator-meanjs/issues/205#issuecomment-193310036 .
This is a result of the underscore.inflections module in the crud module index.js
this.name = props.name;
this.slugifiedName = s(this.name).slugify().value();
this.slugifiedPluralName = inflections.pluralize(this.slugifiedName);
this.slugifiedSingularName = inflections.singularize(this.slugifiedName);
Inflections does have support for adding irregular words, however I have added it in several places including the global modules for the generator and it does not seem to take which may be my misunderstanding of how the generator works.
I think I found the bug in the server route tests template...How do i go about creating a pull request for the fix (am a git/javascript newbie)?
I figured how to create the PR...just one silly mistake...did not create a branch for the fix first..
@Ariestattoo Other than irregular words, it is only limited to English language.
i think it's better to have an option to choose the plural and singular term for each module. And we will use the inflections as a default.
grunt failed in tests/server/routes.test on module named "party" being pluralized as "partys" and "parties" at line 89.