search

meanjs / generator-meanjs

MEAN.JS Official Yeoman Generator
http://meanjs.org/
473 stars 177 forks source link

Fix bug in CRUD module client view route #230

Closed demus closed 7 years ago

demus commented 8 years ago

in the view state, articleResolve.name was hard coded. this fixes with <%= slugifiedSingularName %>Resolve.name

codydaig commented 8 years ago

@water42 Can you take a look at the tests and see why it's failing?

demus commented 8 years ago

It seems to have to do with npm install failing due to permissions errors. I only changed a single variable so I don't think that is the cause of this.

codydaig commented 8 years ago

I just reran them. Let's see what happens this time.

demus commented 8 years ago

does the travis.yml need to be updated? no tests have been in 4 months so I'm wondering if that's the cause.

codydaig commented 8 years ago

@water42 I'm seeing if this fixes it. https://github.com/meanjs/generator-meanjs/pull/232

ilanbiala commented 7 years ago

@codydaig any idea if we still need this PR? @water42 can you try rebasing and we'll see what Travis says now.