search

meanjs / generator-meanjs

MEAN.JS Official Yeoman Generator
http://meanjs.org/
472 stars 178 forks source link

Bump to 0.4.5 #237

Closed codydaig closed 8 years ago

codydaig commented 8 years ago

Fixes eslint errors.

This bump will need to get merged and published, but I do not have permission to publish new versions on npm.

lirantal commented 8 years ago

@codydaig let me know what needs to be done and I'll push it.

codydaig commented 8 years ago

@lirantal #238 is my PR for trying to get travis fixed. I'm not sure what happened but it looks like we're missing the g++ compiler settings. I'll tag you in that PR when it's passing and ready to be merged. Let me know if you have any other insights on that as well on why it might be failing.

lirantal commented 8 years ago

Got it, thanks.

lirantal commented 8 years ago

g++ doesn't seem to be enough, or this is actually related to npm itself?

ilanbiala commented 8 years ago

I'll follow up with the new version and publish it once we fix the issues. Let me get up to speed on all the changes and CI issues.

codydaig commented 8 years ago

Rebased, and waiting for tests to pass.

ilanbiala commented 8 years ago

@codydaig what about the 2 PRs that were closed? Do we not need them anymore? Also, shouldn't we update the Travis CI config to be in line with the main repo's node versions?

codydaig commented 8 years ago

@ilanbiala I only opened those as attempts to fix the builds and I believe they were duplicates. Feel free to reopen the latest one if you want it to match the meanjs repo

lirantal commented 8 years ago

@ilanbiala you're taking care of pushing the fixes here to npm when ready?

ilanbiala commented 8 years ago

Yes, but I want to get in 1 of the PRs that is ready, but just needs to be squashed.

codydaig commented 8 years ago

@ilanbiala When your ready, go ahead and merge this and release. Thanks!

ilanbiala commented 8 years ago

@codydaig sorry I'm a little late, just got back from vacation, merging and publishing.

codydaig commented 8 years ago

@ilanbiala No worries! I'm working full time and a full time student, so my availability is limited.