search

meanjs / generator-meanjs

MEAN.JS Official Yeoman Generator
http://meanjs.org/
473 stars 177 forks source link

Corrected template to pluralize entity name. #240

Closed donohutcheon closed 7 years ago

donohutcheon commented 7 years ago

Correcting the template where it attempts to pluralize the entity name of the crud module. The template was incorrectly concatenating an 's' onto the end of the singular entity name where the inflections module had actually mapped the plural correctly. The correction essentially changes the template to use the pluralized versions of the entity name. This issue is particularly important because it is reproducible by following the meanjs.org superhero / superheroes video tutorial on youtube.com.

donohutcheon commented 7 years ago

Hopefully this can be integrated quickly. Its blocking people from successfully following the meanjs video tutorial on youtube.com and probably hindering adoption of the tool.

lirantal commented 7 years ago

cc @codydaig

ilanbiala commented 7 years ago

@donohutcheon restarted the build.

codydaig commented 7 years ago

@ilanbiala @lirantal The build is failing because of something unrelated to this PR. Once we figure that out, we can get this merged in.

codydaig commented 7 years ago

@donohutcheon Can you rebase from master?

donohutcheon commented 7 years ago

No problem. Please check. I hope I've done it right?

On Mon, Jul 25, 2016 at 9:04 PM, Cody B. Daig notifications@github.com wrote:

@donohutcheon https://github.com/donohutcheon Can you rebase from master?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/meanjs/generator-meanjs/pull/240#issuecomment-235051897, or mute the thread https://github.com/notifications/unsubscribe-auth/ATMgTzBZt70CREFafX-h27vCJK6tTRuVks5qZQjGgaJpZM4JM1iF .

Dono

codydaig commented 7 years ago

Not quite.

  1. Make sure you have your upstream set to this repo.
  2. git pull --rebase upstream master
  3. git push origin 234-crud-module-plural-bug
donohutcheon commented 7 years ago

Thanks, I guess it worked now since the CI build succeeded.

Regards, Donovan

On Tue, Jul 26, 2016 at 7:45 PM, Cody B. Daig notifications@github.com wrote:

Not quite.

  1. Make sure you have your upstream set to this repo.
  2. git pull --rebase upstream master
  3. git push origin 234-crud-module-plural-bug

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/meanjs/generator-meanjs/pull/240#issuecomment-235347638, or mute the thread https://github.com/notifications/unsubscribe-auth/ATMgT17IzN5i02ohJHjcUDXKfvjQue6Bks5qZke3gaJpZM4JM1iF .

Dono

ilanbiala commented 7 years ago

The CI build actually failed. Can you try to fix it so we can include in 0.4.5?

donohutcheon commented 7 years ago

Hi, Are you sure? Following link says all passed: https://travis-ci.org/meanjs/generator-meanjs/builds/147312373 I'm new to git hub so I might have it wrong. My changes are fairly trivial if they are breaking the build I'll be surprised. Regards, Donovan

On 28 Jul 2016 2:15 AM, "Ilan Biala" notifications@github.com wrote:

The CI build actually failed. Can you try to fix it so we can include in 0.4.5?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/meanjs/generator-meanjs/pull/240#issuecomment-235760870, or mute the thread https://github.com/notifications/unsubscribe-auth/ATMgT90QrWmnr_Su9rj6TAqqvwHAYh5qks5qZ_SogaJpZM4JM1iF .

ilanbiala commented 7 years ago

@donohutcheon are you looking at the build status at the bottom of this PR? Here it says failed and if you click on details you can see the build specifically.