search

meanjs / generator-meanjs

MEAN.JS Official Yeoman Generator
http://meanjs.org/
473 stars 177 forks source link

Update Gulp to fix npm install errors #241

Closed therobinkim closed 7 years ago

therobinkim commented 7 years ago

This commit updates Gulp to the latest snapshot of its 4.0.0-alpha.2 branch, effectively bringing in changes made from 9 Nov 15 to 27 Jun 16.

This commit allows npm install to run successfully once more. npm test runs successfully as well.

You can see Gulp's changes here https://github.com/gulpjs/gulp/compare/3311fcab7fe6de65a7a981d2433205c91d151c0a...d8f5c90a0622d19ef1943a2a3d02dc50e3c853e7

I would've just put https://github.com/gulpjs/gulp.git#4.0 in package.json to it'd always pull in the latest snapshot, but I figured I'd lock the dependencies into a very specific commit since the original commit on 21 Dec 15 by ilanbiala did so.

Edit: Woo hoo, tests passing!

ilanbiala commented 7 years ago

LGTM. @meanjs/contributors any thoughts before I merge?

codydaig commented 7 years ago

First, Hi @therobinkim!!!!!!! I didn't know you followed this repo!!

Secondly, Let's merge!!

lirantal commented 7 years ago

Cool with me