search

meanjs / generator-meanjs

MEAN.JS Official Yeoman Generator
http://meanjs.org/
473 stars 178 forks source link

Fix for issue #254 Update _.server.model.tests.js #255

Open mringer opened 7 years ago

mringer commented 7 years ago

Fixes MochaJS MochaJS Resolution Method Over Specification in test template code.

ilanbiala commented 7 years ago

@matthewringer why is the return not necessary anymore?

codydaig commented 7 years ago

@ilanbiala According to #254, it's returning a promise and calling .done() in which they claim causes issues with Mocha. I have not yet experienced this, but can see what might be happening.

mringer commented 7 years ago

@ilanbiala as @codydaig mentioned returning the promise and calling .done() which raises an exception with Mocha. There is a more extensive description of the problem in the original issue, and here is an instance of the same issue from Mocha's repo.

Let me know if you have any other questions.

ilanbiala commented 7 years ago

@codydaig LGTY?