search

meanjs / generator-meanjs

MEAN.JS Official Yeoman Generator
http://meanjs.org/
473 stars 177 forks source link

Simple test enhancement #257

Open jrodenbostel opened 7 years ago

jrodenbostel commented 7 years ago

I'm proposing this small change to help diagnose ignored save errors while testing CRUD module server routes, specifically testing the case that covers someone 'should not be able to delete an <%= humanizedSingularName %> if not signed in'. I'm working on a project where the request param and model property names don't match in all cases, and having this change in place helped me diagnose an issue that had taken an embarrassingly long time to fix.

codydaig commented 7 years ago

@jrodenbostel

Sorry for the delay in response. I'm all for this. However, this stems from the project. So if you can make the PR over there (github.com/meanjs/mean) and get it merged, I'm happy to merge this.

jrodenbostel commented 7 years ago

@codydaig No problem. Not sure I follow your suggestion, though. Are you saying that I should make this change to the article module's server/route tests (https://github.com/meanjs/mean/blob/master/modules/articles/tests/server/article.server.routes.tests.js)?