search

meanjs / generator-meanjs

MEAN.JS Official Yeoman Generator
http://meanjs.org/
472 stars 178 forks source link

fixed blank page caused by faulty menu injector #277

Open ai-nick opened 7 years ago

ai-nick commented 7 years ago

This is intended to fix the generator error that can be seen at 13:00 of this video https://www.youtube.com/watch?v=a-dn6k6Frq4&t=769s I am confused as to why the build failed, checked the logs and I am trying to figure it out but any help would be appreciated

lirantal commented 7 years ago

thanks. we'll review

ai-nick commented 7 years ago

Hey thanks for letting me know!

Sent from my iPhone

On Jun 28, 2017, at 11:27 AM, Liran Tal notifications@github.com<mailto:notifications@github.com> wrote:

thanks. we'll review

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/meanjs/generator-meanjs/pull/277#issuecomment-311730443, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AQzrBitRYJ8AvDe0UE3IOKpcTbOLXt8lks5sIoz8gaJpZM4OFwmz.

ai-nick commented 7 years ago

Thanks cody! do you think it might be that im using an older version, for some reason when i use yo generate meanjs, it templates my core with the menu service name "Menus", here is a link to my c9: https://ide.c9.io/nickwilliamswebdev/webdev-bootcamp , feel free to poke around.

ai-nick commented 7 years ago

I believe when using the yo generator to create the project, this is the template being used for the core module: https://github.com/meanjs/generator-meanjs/blob/master/angular-config/templates/_.client.config.js Maybe we could just change generator-meanjs/angular-config/templates/_.client.config.js of the mean generator to be menuService to match everything else, should I submit a pull request for this and close this one? (last edit, I will delete the .DS_Store files :))