search

meanjs / mean-seo

SEO Solution for MEAN.JS applications using PhantomJS.
72 stars 36 forks source link

Add pushstate support, rediscloud support, and tests #7

Closed tvararu closed 10 years ago

tvararu commented 10 years ago

Hope I'm not stepping on anyone's toes; I decided to use mean-seo for one of my own projects and I had some fairly specific needs that weren't satisfied by the basic package. Firstly, I needed HTML5 pushstate support, as detailed in #6, and then I also needed the redis client to support rediscloud (for Heroku).

For the former, I refactored logic in lib/mean-seo.js to support both style of URLs and save them properly to the key-value store.

For the latter, there is now a redisURL option (courtesy of @dapetcu21) that coerces the redis client into using your specified URL.

I also added a few basic tests, and a travis-ci config file. (here's a successful build)

This shouldn't break the existing API in any way, but should add functionality. Let me know if there is anything that you don't think is proper and I can fix it and submit another PR.

This closes #6 and #5.

rschwabco commented 10 years ago

Thanks @tvararu, I'm going to push this very soon. Sorry it took so long.

devnix commented 10 years ago

Any clue about this? It will be pushed soon or I have to integrate on my own fork if I need this in the next couple of weeks? :D

simon-at-angelsdice commented 10 years ago

Do you know when this will be pushed?

rschwabco commented 10 years ago

Thanks for the PR @tvararu !

tvararu commented 10 years ago

No problem! :100: