search

meanmail-dev / nginx-intellij-plugin

Intellij Plugin for Nginx configuration file
https://meanmail.dev/plugin/7
MIT License
56 stars 6 forks source link

Added compatibility for IDE version 2022.2 #13

Closed gtsatsis closed 2 years ago

gtsatsis commented 2 years ago

Hi,

I've gone ahead and versioned the plugin for IntelliJ 2022.2; Initially, I was aiming to support multiple versions, but seeing as there are tags for each individual version, I'm not sure how to proceed;

This is my first ever interaction with the Jetbrains Plugin ecosystem, so if I messed something up, please let me know, but initial testing in GoLand 2022.2.2 (GO-222.3739.57) indicates that it works!

This PR should close #12.

sbakic commented 2 years ago

Still not merged. Soon we will have IntelliJ 2022.3, and this will become obsolete. :face_exhaling:

gtsatsis commented 2 years ago

Still not merged. Soon we will have IntelliJ 2022.3, and this will become obsolete. 😮‍💨

Considering the original maintainer (:wave: hi @meanmail, mentioning in case I can get your attention) is MIA in relation to their Jetbrains plugins, I don't expect a merge to take place, but I'll keep updating my own fork whenever I see fit for my use-case.

Keep in mind that my commit, 81467abc6081ca743157768e2e22e85d2a1a6f1b can be used as an example if anyone else feels like maintaining the plugin as a fork.

apokryfos commented 2 years ago

@gtsatsis is there a way to use your patched branch? I've tried checking it out and running ./gradlew buildPlugin and got the build directory created but not sure what I can do with this now.

gtsatsis commented 2 years ago

@gtsatsis is there a way to use your patched branch? I've tried checking it out and running ./gradlew buildPlugin and got the build directory created but not sure what I can do with this now.

@apokryfos: if the build succeeded, you should be able to install the compiled plugin from the zip file at ./build/distributions/nginx-intellij-plugin-<version>.zip.

Note that you'll have to manually install the plugin, so for example with IDEA, the flow would be: File -> Settings -> Plugins -> (cog icon in the plugins page) -> Install Plugin from Disk...

meanmail commented 2 years ago

Fixed in new version