measurement-kit / measurement-kit-node

Node.js bindings for measurement-kit [discontinued]
https://measurement-kit.github.io
BSD 3-Clause "New" or "Revised" License
1 stars 1 forks source link

bindings: reduce the code smell #8

Closed bassosimone closed 6 years ago

bassosimone commented 6 years ago

@hellais I recommend looking into each commit on it own. Detail of changes:

Perhaps more refactoring can be implemented in the future, but for now this seems to me a good move forward to make the code in here more obvious.

After this is merged, I can move on with making sure we wrap all we need to wrap.

hellais commented 6 years ago

I took a look at the commits and it looks much better like this. I am going to proceed in merging.

bassosimone commented 6 years ago

Very well :-)