search

meateam / api-gateway

api gateway
Apache License 2.0
10 stars 4 forks source link

hotfix: Improved metrics #217

Closed Shahar-Y closed 3 years ago

Shahar-Y commented 3 years ago

Added appID and AuthType to the metrics, with an option to add mre info from claims. No breaking changes, and tested with kibana locally Signed-off-by: shahar-y shya95@gmail.com

Shahar-Y commented 3 years ago

Dear @Shahar-Y, please remove the dropbox changes because it is impossible to review both changes that are unrelated to each other. Furthermore, If I would approve it, the dropbox changes might not get reviewed and still be in the develop. Quick solution: open a new branch from dropbox branch, and open PR from hotfix: Improved metrics to the new branch and the changes should not appear.

But that's what I did, here: https://github.com/meateam/api-gateway/pull/220

Shahar-Y commented 3 years ago

Closing in favor of #223