'ApplicationError' should have a constructor with no params.

meateam / seal

MIT License

4 stars 0 forks source link

'ApplicationError' should have a constructor with no params. #44

Closed yonatandt closed 6 years ago

yonatandt commented 6 years ago

It seems like @Shahar-Y intended to do that, but only did half the job. If you want to have an 'Undefined Application Error' you'll have to create the Error like this: new ApplicationError(undefined, undefined) Which seems rather odd and ugly.

yonatandt commented 6 years ago

A simple solution will be just to add ? to the params of the ApplicationError constructor. Lets fix that.