search

meatpiHQ / wican-fw

GNU General Public License v3.0
293 stars 57 forks source link

Re-enable FTP for CAN/MQTT Filters (?) #87

Open brodykenrick opened 7 months ago

brodykenrick commented 7 months ago

The FTP feature referenced here looks awesome: https://github.com/meatpiHQ/wican-fw/issues/66#issuecomment-1748732228

It seems to have been turned off again though, this commit: https://github.com/meatpiHQ/wican-fw/commit/f4f2f86d15a4ddf57ff5542326bc1192fe5371f6#diff-2978fe1c2c45b4eca89dc476376ddc7193bc4e5e7fff0c7d1c465f057b35a5e6L507

That FTP access would be so useful in setting CAN filters, especially because of the odd glitch in the add//delete store process that sometimes means you accidentally delete the rules you wanted to keep.

Was there a reason for disabling FTP again? Or is it something that could be re-enabled?

meatpiHQ commented 7 months ago

@brodykenrick I can send you a firmware with FTP enabled if you like.

Its disables because it's not reliable, and can cause issues in some cases. Which means more support tickets :)

I plan to fix it at some point.

brodykenrick commented 7 months ago

Thanks. It is OK, no need to send a custom FW.

Whenever FTP is back working properly is good.

The glitches in the add/delete are the main issue and what was driving me to FTP.

I'll look to reproduce those and hopefully that can bea more useful fix for many more folks.