meatyite / python-socialblade

Object oriented SocialBlade API wrapper
The Unlicense
18 stars 9 forks source link

StoryFireUser.get_subscriber_count needs to use regex #7

Closed meatyite closed 4 years ago

meatyite commented 4 years ago

image @SuperSonicHub1 i think StoryFire needs to use regex too

SuperSonicHub1 commented 4 years ago

Oh yes, I've seen this error before. I believe it is the way that Socialblade's API redirects users who make an invalid query. Let me do some investigation and get back to you.

Kyle Williams

On Tue, Jul 21, 2020 at 7:37 AM Amir Yosef Perehodnik < notifications@github.com> wrote:

[image: image] https://user-images.githubusercontent.com/43294802/88050456-91670180-cb5f-11ea-947c-7bc71c1bb35e.png @SuperSonicHub1 https://github.com/SuperSonicHub1 i think StoryFire needs to use regex too

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/sl4vkek/python-socialblade/issues/7, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGDQCMRJJQJWNEUYDLHGH4LR4V4XHANCNFSM4PDPW25A .

SuperSonicHub1 commented 4 years ago

After doing a bit of investigation both within Python and the Network tab of Chrome, I have come to the conclusion that the issue with StoryFireUser is not with our code, but instead with either Cloudflare, and by extension cloudscraper, or is Socialblade's way of blocking external users. I say this because the same error occasionally takes place with TwitchUser, although on a much smaller scale. If it is the former, I would suggest you start an issue with Cloudscraper. If it is the latter, we'll have to figure something out, or at least leave a warning that the function doesn't function 100% of the time

(P.S. I sent a message to you yesterday but it seemingly didn't get submitted. Sorry for the late response.)

meatyite commented 4 years ago

@SuperSonicHub1 Yes we should write a warning. We should also maybe modify StoryFireUser.live_subscriber_count_generator's default request delay, since it will error more times?

SuperSonicHub1 commented 4 years ago

Cool. I'll get on it.

Kyle Williams

On Thu, Jul 23, 2020 at 8:05 AM Amir Yosef Perehodnik < notifications@github.com> wrote:

@SuperSonicHub1 https://github.com/SuperSonicHub1 Yes we should write a warning. We should also maybe modify StoryFireUser.live_subscriber_count_generator's default request delay, since it will error more times?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/sl4vkek/python-socialblade/issues/7#issuecomment-662968353, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGDQCMUJ3OFFI3QDMFDOJTLR5ARPFANCNFSM4PDPW25A .

SuperSonicHub1 commented 4 years ago

8. Check it out.

meatyite commented 4 years ago

Merged and updated to pypi. Next up: add examples for Dailymotion