Closed GoogleCodeExporter closed 8 years ago
[deleted comment]
Make changes to DeviceScreen.java, as seen in the attached file so the WM 5.0
Smartphone softkeys show up and also so the joystick button works.
(Tabs have been changed to four spaces in this file. You should change them
back to
tabs.)
Kevin
Original comment by kdarl...@basit.com
on 4 Dec 2007 at 11:09
Attachments:
Great... it fixes the problem.
May you commit this fix to code repository ?
Jean-Marie
Original comment by jmherme...@gmail.com
on 5 Dec 2007 at 8:41
I do not have the Tao JVM available for testing so I'll have to rely on you for
it.
But the fix is excellent. I will integrate it into the library and issue a
patch
after reviewing the other open issues.
Original comment by deanbro...@gmail.com
on 11 Dec 2007 at 1:48
Ugh. You can tell I was in a hurry to post that patch code. I'd make two
changes
before integration:
1) the check for the tao platform should ignore case:
if (platform.toLowerCase().indexOf("intent") > -1)
tao = true;
else
tao = false;
2) don't hardcode -8 , and return immediately:
// tao center joystick button gives Carriage Return
//
if (tao && (key == 13))
{
return DeviceScreen.FIRE;
}
Original comment by kdarl...@basit.com
on 11 Dec 2007 at 3:26
Original comment by deanbro...@gmail.com
on 13 Dec 2007 at 12:58
Test Report with J4ME 1.0.1 :
Fire button does not work on QTEK 8310, but acts normally on HTC S620
On Qtek 8310 - JVM v10.1.7.529 (B:20050817) = fire button = 8
On HTC S620 - JVM 10.1.7.561 (B:20060726) = fire button = -8
Original comment by jmherme...@gmail.com
on 13 Dec 2007 at 5:35
Original comment by deanbro...@gmail.com
on 13 Dec 2007 at 6:39
on 1.0.1 the following is wrong :
if(tao)
{
if(key== 13)
return FIRE;
}
should be
return DeviceScreen.FIRE
Original comment by jmherme...@gmail.com
on 18 Dec 2007 at 11:39
Since I blew it last time can I have you check something for me?
See if it works for both phones. Substitute the Tao code at the top of 1.0.1's
`translateKeyCode' for the if statement below.
{{{
/**
* Maps key values to the constants defined in the outter class.
*
* @param key is code of the button pressed.
* @return The integer value for the key.
*/
private int translateKeyCode (int key)
{
// Some phones have a bug where they treat the FIRE key as "Enter".
if ( tao && (key == 13) )
{
return DeviceScreen.FIRE;
}
}}}
Original comment by deanbro...@gmail.com
on 18 Dec 2007 at 4:44
Dean, Key behaviour works as expected on four Windows Mobile device :
- QTEK 8310 + Tao JVM
- HTC S620 + Tao JVM
- QTEK 9100 + Tao JVM
- HTC Touch + Esmertec JVM
Original comment by jmherme...@gmail.com
on 21 Dec 2007 at 9:06
Original comment by deanbro...@gmail.com
on 24 Dec 2007 at 12:22
Original comment by deanbro...@gmail.com
on 24 Dec 2007 at 1:43
Original comment by deanbro...@gmail.com
on 17 Jan 2008 at 7:02
Original issue reported on code.google.com by
jmherme...@gmail.com
on 4 Dec 2007 at 1:32