mebemot / reacttactoe

tictactoe and connectfour game PWA using react
https://improvements-from-react.d2fcfr3e9w6oci.amplifyapp.com/
0 stars 0 forks source link

Improvements from react #15

Open mebemot opened 4 years ago

mebemot commented 4 years ago

Changes Between Branches

PWA

Connectfour has been added

Both Games have become part of a single app

Components have been refactored

Thank You For Your Time!

Jo-R commented 4 years ago

Hey, so this is really good work :-) Hope the comments so far are useful. I haven't really looked at tic tac toe so far but at a quick glance it looks similar structure so a lot of the comments above apply to both (and obviously other comments might apply where you've done similar stuff in other places).

I'm a bit in holiday brain mode this afternoon so haven't really looked properly at the ConnectfourRules file but I will have another look at the weekend sometime if you're up for more comments? (I'll also have a look at the css and see if there's anything I can add there...and I'm totally going to have a look at your tests but that's because we have zero tests for the webapp I work on and we need to sort that at some point and er I've never written any React tests so I'll probably learn something off you there!).

Also, if any of the stuff I've said is unclear just let me know and I can probably dig out examples etc (and I'm not perfect by any means so also feel free to disagree with some of the suggestions :-))