search

mebigfatguy / fb-contrib

a FindBugs/SpotBugs plugin for doing static code analysis for java code bases
http://fb-contrib.sf.net
GNU Lesser General Public License v2.1
157 stars 45 forks source link

[maven] Bump maven wrapper to 3.3.2 #432

Closed hazendaz closed 3 months ago

hazendaz commented 2 years ago

Maven wrapper application is performed via

mvn -N org.apache.maven.plugins:maven-wrapper-plugin:3.2.0:wrapper -Dtype=source

At the moment, maven is still using legacy http url for apache license so I further run a git bash alias to do above plus the following.

sed -i 's,http://www.apache.org/licenses/LICENSE-2.0,https://www.apache.org/licenses/LICENSE-2.0,g'

So we do not promote http usage there. I'm raising a PR to maven in that regard. Will also be raising other items related to maven wrapper but note that in reality it takes maven years sometimes to apply simple things. Last PR I had to them took nearly a year to get merged and released.

hazendaz commented 2 years ago

@ThrawnCA Maven licenses the files now, this is a script (ie maven wrapper plugin with type source), it comes with the license headers as indicated as files are not owned by individual repos but by th originating source (ie maven). This changed over time as this was not originally a maven project, but apache took it and maven now owns it since 3.0.0.

hazendaz commented 1 year ago

@mebigfatguy may as well merge this, 3.2.0 is in voting so to keep diff slightly cleaner, probably best to apply this as-is then pick that up afterwards.

hazendaz commented 1 year ago

Re-based this PR, changed PR message and commit message and now to latest maven wrapper 3.2.0.

hazendaz commented 1 year ago

Note: these files all come from maven. Only adjustment I've done is to use https on their license so we are not promoting redirects to apache license. Application otherwise is a maven plugin run of maven wrapper.

mvn -N org.apache.maven.plugins:maven-wrapper-plugin:3.2.0:wrapper -Dtype=source
hazendaz commented 11 months ago

@mebigfatguy Can we get this merged? I'll follow up with more as its out of date again but this is at least getting closer...

hazendaz commented 5 months ago

Re-updated to 3.3.2