search

mebigfatguy / fb-contrib

a FindBugs/SpotBugs plugin for doing static code analysis for java code bases
http://fb-contrib.sf.net
GNU Lesser General Public License v2.1
157 stars 45 forks source link

Drop Travis, Board Github Actions, Update build so it mostly functions (see details) #458

Closed hazendaz closed 3 months ago

hazendaz commented 11 months ago

This is a large effort. The build with maven did not work. One class specifically for akka was using bcel but failed to have import for same. After fixing that it was very clear to me at least that the maven build is effectively not used (ant is used). I recall trying to help get this project to maven years ago off pretty obsolete ant so I guess that was never finished and will be a very long road. At any rate, the effort here gets the build pom as up to date as I could, many pmd issues resolved, left cpd and spotbugs violations with noted number of issues.

This pulls part of another change of mine to drop checking in IDE files or auto generated in general.

Aside from that, the main point was to drop travis as not OSS friendly for years now and get this on GHA which it is now building successfully as noted for java 8, 11, 17, 21, and 22-ea

hazendaz commented 11 months ago

note: the ant build could also be added to GHA and build there, no real concern there. And in a twist, we could use maven to invoke ANT instead so this does it all. That is assuming transition to maven is favorable to start with. It could always remain separate but that would at least allow both build tools to physically work. I've done that before in a number of edge cases where some items that maven needs are not available but ant has no issues. Food for thought I guess...