search

mebis-lp / mod_learningmap

GitHub Repository for mod_learningmap
https://moodle.org/plugins/mod_learningmap
GNU General Public License v3.0
13 stars 6 forks source link

Call to undefined function mod_learningmap\array_remove_by_value #67

Closed Menrath closed 1 year ago

Menrath commented 1 year ago

Reported by: https://bildung.social/@FrauBainski/109834002858374211

Possible solutions:

  1. Probably the fallback to global namespace should be enforced in https://github.com/mebis-lp/mod_learningmap/blob/1f9f1274919ddd46c76b6237f7156540dde0cbf6/classes/mapworker.php#L308

  2. Maybe it is better to replace this function by just changing the line to array_values(array_diff($active, array($path['id']))); cause array_remove_by_value has no phpdocs, proper type checks and so on.

sh-csg commented 1 year ago

Thanks for reporting! This is already fixed in v0.9.2