search

mebis-lp / moodle-mod_mootimeter

Other
8 stars 7 forks source link

styles.css incorrectly listed in thirpartylibs.xml file #84

Closed danmarsden closed 4 months ago

danmarsden commented 4 months ago

as mentioned in #77 - the styles.css entry shouldn't be in the thirdpartylibs.xml file.

PhMemmel commented 4 months ago

Hi @danmarsden,

I agree, but as long as https://tracker.moodle.org/browse/MDL-81263 is integrated, there is no proper way of making grunt ignore the styles.css, so the GHA will not pass. So we had to add it to the thirdpartylibs.xml in the meantime. Feel free to push MDL-81263 forward :-)

danmarsden commented 4 months ago

if your aim is to just do this for github actions - I'm curious to know if a env var like this works?

env:
 CODECHECKER_IGNORE_NAMES: 'styles.css'

but all good - we won't block approval on this one.

PhMemmel commented 4 months ago

Hi @danmarsden, thank you for the hint. I tested (see branch test_GHA_ignore and associated GHA runs) and unfortunately your proposed solution does not work, because it's not a codechecker issue, but grunt stylelint which has no env variable like codechecker. So we will have to stick with the thirdpartylibs "hack" until MDL-81263 is being integrated.

danmarsden commented 4 months ago

thanks - good to know!