search

mecachisenros / woocommerce_civicrm

GNU Affero General Public License v3.0
14 stars 16 forks source link

Plugin refactoring #15

Closed mecachisenros closed 5 years ago

mecachisenros commented 7 years ago

This is not an issue but rather a question.

I've recently run into a small issue with the latest WC 3.0+ where the order properties cannot be accessed directly anymore (protected properties) and we have to use getter methods like get_billing_email() so I've gave it a go and refactored the plugin aiming for, hopefully, get it ready for publishing in the WordPress plugin directory.

The question: would you @veda-consulting be interested in publishing it?

I've created a v2.0 branch, I can prepare a PR and I'll be happy to help improving the integration.

mecachisenros commented 7 years ago

@veda-consulting I've made a few more improvements, support for State/Province, added a few hooks and an option to sync woocommerce/civicrm mapped addresses both ways #4

veda-consulting commented 7 years ago

@mecachisenros thanks for those, if you can prepare a PR we would be happy to release version 2.0

mecachisenros commented 7 years ago

@veda-consulting perfect, I just need to push a couple more fixes and then I'll prepare the PR, ETA tomorrow evening

mecachisenros commented 7 years ago

@veda-consulting as promised, PR created, feel free to review/ask clarifications

veda-consulting commented 7 years ago

Great thanks, we'll get onto it

Parvez Saleh

Managing Director

vedaconsulting.co.uk

+44 (0) 33 3011 8874 <#UNIQUE_IDSafeHtmlFilter>

90 Mainyard, 90 Wallis Rd London, E9 5LN

https://twitter.com/vedaconsulting https://www.facebook.com/vedaconsulting https://uk.linkedin.com/in/vedaconsulting

On 25 July 2017 at 19:14, Andrei Mondoc notifications@github.com wrote:

@veda-consulting https://github.com/veda-consulting as promised, PR created, feel free to review/ask clarifications

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/veda-consulting/woocommerce_civicrm/issues/15#issuecomment-317821849, or mute the thread https://github.com/notifications/unsubscribe-auth/ACVb_kioAi6xZ2fBzLEYFnc5G9T2JGWwks5sRjCIgaJpZM4OMxZv .