search

mecachisenros / woocommerce_civicrm

GNU Affero General Public License v3.0
14 stars 16 forks source link

Become maintainer/put out new release? #28

Open JoeMurray opened 3 years ago

JoeMurray commented 3 years ago

@sabrinaleroy @bastienho you two seem to be maintaining this plugin. I'd encourage you to become the maintainer and maybe put out a new release. Thanks for sharing!

ralphyke commented 3 years ago

It's a really great plugin. I've found what looks like a bug:

When using the lineitem editor extension in Civi, when changing the Financial Type on a record, it sort of hangs (gives the little whirly thing) but the update is done, as pressing escape and then refreshing shows the update. However, after talking to JMA Consulting who support that extension, they have pointed out that the line-item is not linked with the financial item, and that maybe there is an incorrect adjustment made during recording the payments via WooCommerce.

ralphyke commented 3 years ago

Would also be good if it was enhance to be able to create memberships in Civi but that's probably more complicated and would have to use the WooCommerce members plugin which is paid for, although there could be ways around that. I noticed that there is perhaps something built in but not yet released because if there is not a _civicrm_membership meta_key entry for 0 in the wp_postmeta table, it tries to create a membership but fails with a foreign key constraint (I don't know how this happened so I had to insert a _civicrm_membership record for this to solve the problem). The only difference I could see with other purchases was that the person signing up put "member" as their title.

JoeMurray commented 3 years ago

Heh @ralphyke ! Not sure if you noticed, but JMA will be fixing the first point above shortly https://github.com/mecachisenros/woocommerce_civicrm/issues/32 . On the second point, it might be useful to create a different issue or two.

ralphyke commented 3 years ago

Hi, thanks for the feedback but do you mean that JMA are going to make a change to WooCommerce CiviCRM WP Plugin or their extension because I think the problem is in the WooCommerce CiviCRM WP Plugin?

JoeMurray commented 3 years ago

We're going to submit a fix here on this repo.

ralphyke commented 3 years ago

Brilliant, thanks

bastienho commented 3 years ago

Heh @ralphyke ! Not sure if you noticed, but JMA will be fixing the first point above shortly #32 . On the second point, it might be useful to create a different issue or two.

That's great, @sabrinaleroy and I were going to work on it.

We now have to merge all forks /branches for a stable version

agileware-justin commented 3 years ago

Might want to test #33