search

mecachisenros / woocommerce_civicrm

GNU Affero General Public License v3.0
14 stars 16 forks source link

Fail to change status of related contribution when order status is changed to Completed to Cancelled #32

Open monishdeb opened 3 years ago

monishdeb commented 3 years ago

Change status of any existing completed order to 'Cancelled'. It doesn't able to update the linked Contribution status to 'Cancelled' and on debugging the error message here I got : 

Expected one FinancialItem but found 0

It seems that there is no linked FinancialItem with the contribution's line-item(s), and thus it causes an issue on order status change.

JoeMurray commented 3 years ago

JMA will be submitting a fix for this shortly.

agileware-justin commented 3 years ago

@JoeMurray might want to check #33

monishdeb commented 3 years ago

@agileware-justin thanks for the patch, will review it shortly and provide my feedback on PR itself.

agileware-justin commented 3 years ago

@monishdeb there is also #34 and #35 as well for review if you have time.

monishdeb commented 3 years ago

Sure will do 👍

agileware-justin commented 3 years ago

Change status of any existing completed order to 'Cancelled'. It doesn't able to update the linked Contribution status to 'Cancelled

@monishdeb this works from my testing, suggest you confirm same and if so, then mark this issue as fixed.