search

mecamira / dxf2gcode

Automatically exported from code.google.com/p/dxf2gcode
0 stars 0 forks source link

Reversing of imported splines gives strange results #42

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
If the attached single letter n (file: Buchstabe_n.dxf) is imported the result 
shape looks strange and the generated gCode is not accepted by LinuxCNC.

Fix is attached.

Original issue reported on code.google.com by Anton.ma...@gmail.com on 2 Jan 2014 at 3:15

Attachments:

GoogleCodeExporter commented 9 years ago 
Hello Anton,

i just checked the Import of the dxf. I dont see any mistake during the Import 
for my newest trunk Version of dxf2gcode. Which Version / download etc did you 
use to test it?
Please see my attached jpeg to check the result.

regards
Christian

Original comment by christian.kohloeffel on 2 Jan 2014 at 5:59

Attachments:

GoogleCodeExporter commented 9 years ago 
Just had a look on the diff file in order to have a better understanding but i 
don't see where this diff shall be applied.
can you tell me the line number here:
http://code.google.com/p/dxf2gcode/source/browse/trunk/source/dxf2gcode.py

Original comment by christian.kohloeffel on 2 Jan 2014 at 6:11

GoogleCodeExporter commented 9 years ago 
Hello,

with the trunk version from 02.01.2014 afternoon I get the attached result on 
Ubuntu 12.04 and 13.10. The import calculates 5 arcs of the spline in the 
letter and creation of the sharps in dxf2gcode.py (around line 819) reverses 
the arc list on every arc processed. And as the for loop has an else statement 
the arc list is added twice to the shapes.

The diff is a "diff -u" on the trunk file and the changed file. diff -u 
produces an unified diff which can be applied using patch. in the first two 
lines of the diff the files are listed, in the third line are the affected line 
numbers and the rest is the difference between the files.

Original comment by Anton.ma...@gmail.com on 2 Jan 2014 at 11:28

GoogleCodeExporter commented 9 years ago 
And here the picture

Original comment by Anton.ma...@gmail.com on 2 Jan 2014 at 11:32

Attachments:

GoogleCodeExporter commented 9 years ago 
Hi Anton, 

i see. I was a bit confused cause in my Version everthing worked. This has been 
a Change just done by another developer which caused the issue. Now with doing 
the update i saw the issue and fixed it already. Please try the new Revision on 
the SVN. Please give Feedback if I'm wrong. 

regards
Christian

Original comment by christian.kohloeffel on 3 Jan 2014 at 7:58