Applications using playwright-elixir must independently install playwright js

mechanical-orchard / playwright-elixir

An Elixir library for Playwright web automation

MIT License

119 stars 23 forks source link

Applications using playwright-elixir must independently install playwright js #20

Closed sax closed 2 years ago

sax commented 2 years ago

This adds an extra integration step to every application that tries to use this library.

Ideas:

Add documentation about this dependency and how to resolve it.
playwright-elixir can ship playwright in its priv directory.
This library can check for playwright being installed in the environment, and tell you how to install it.

sax commented 2 years ago

One thing to watch out for is a match between this library's known compatibility with the installed version of playwright. If there is a mismatch, this library at the very least should print a warning.

coreyti commented 2 years ago

I believe this is handled in the "Bundle/config Playwright node CLI" commit.

@sax, thoughts?

coreyti commented 2 years ago

Closing, as I believe this is resolve.