Allows type support for no_wait_after and timeout in locator calls.

mechanical-orchard / playwright-elixir

An Elixir library for Playwright web automation

MIT License

119 stars 23 forks source link

Allows type support for no_wait_after and timeout in locator calls. #33

Closed dbrody closed 2 years ago

dbrody commented 2 years ago

Updates to allow timeout and no_wait_after options to the types for locators.

coreyti commented 2 years ago

I made a small change: options_with_delay -> options_keyboard. There's no solid pattern yet established for naming those types; this somehow felt better.

Incidentally, I was hoping to find some tests in the official implementations that we could port. Sadly, there are none.