mechboxes / mech

Easy command line virtual machines for VMWare
https://mechboxes.github.io/mech/
MIT License
311 stars 49 forks source link

Python 3 support, unpause command, & minor fixes #23

Closed juntalis closed 6 years ago

juntalis commented 6 years ago

Not sure how you feel about maintaining Python 3 compatibility, but I figured I'd offer the changes and see if you want any of them. Let me know if you'd like me to split something out. Brief overview of the changes:

mech scp ubuntu-vm /home/mech/file.txt file.txt

would've previously tried to download home/mech/file.txt.

Note: Tested each command in Python 2.7 and 3.6, but only on Windows. (didn't have a Linux dev environment handy when I was writing the changes)

ColdHeat commented 6 years ago

Hey there @juntalis! You should check out the devel branch https://github.com/mechboxes/mech/tree/devel.

A lot of rewrites and it should be compatible with Python 3. There are some unimplemented commands there too but it is a little more complicated to jump into than the master branch.

juntalis commented 6 years ago

Woops - completely overlooked that branch. Will check it out and see if any of my changes still apply. In any case, closing this pull request.

Kronuz commented 6 years ago

Yes, please check devel branch. It’s not Python 3 compatible yet, we need to make it compatible though. We can either use six or add a compat module. Please make a new pull request for that branch if you can.