search

mechboxes / mech

Easy command line virtual machines for VMWare
https://mechboxes.github.io/mech/
MIT License
311 stars 49 forks source link

Is this repo still alive? #70

Open mkinney opened 4 years ago

mkinney commented 4 years ago

Is this repo still active? I have a few PRs open. I've not seen any responses from maintainer(s).

I've been working on a fork: https://github.com/mkinney/mech/tree/multi-pr and I'd really like to merge these changes into this repo.

I've been experimenting using github for mech work: https://github.com/mkinney/mech/projects/1 which is based on my desires as well as some of the open issues in this repo.

I've re-written quite a bit. I've got some integration tests that validate most of the functionality. Since they are integration tests, I cannot do any sort of code coverage reporting.

mkinney commented 4 years ago

Forgot to mention that multiple instances works on this branch. See https://github.com/mkinney/mech/blob/multi-pr/tests/int/two_ubuntu/Mechfile

ColdHeat commented 4 years ago

I generally don't engage too much on this repo since a lot of the code was re-written by @Kronuz from what I originally wrote and I don't generally use it as part of my workflow but I'm willing to merge in some PRs and make releases.

I do wish that there were more tests here though.

mkinney commented 4 years ago

I have not added any unit tests, mainly because I don't really understand how to implement them based on the docstrings being functional arguments.

But, I've added most functionality integration tests. Check out: https://github.com/mkinney/mech/blob/multi-pr/tests/int/README.md

mkinney commented 4 years ago

Created https://github.com/mechboxes/mech/pull/71

mkinney commented 4 years ago

BTW, I have since added unittests. They take under 2 seconds to run (with 4 procs):

mikekinney@sweet mkinney_mech % pytest --cov mech
================================================== test session starts ===================================================
platform darwin -- Python 3.7.6, pytest-5.3.5, py-1.8.1, pluggy-0.13.1
rootdir: /Users/mikekinney/python/mkinney_mech, inifile: pytest.ini
plugins: mock-2.0.0, xdist-1.31.0, forked-1.1.3, cov-2.8.1
gw0 [118] / gw1 [118] / gw2 [118] / gw3 [118]
.................................................................................................................. [ 96%]
....                                                                                                               [100%]Coverage.py warning: No data was collected. (no-data-collected)

---------- coverage: platform darwin, python 3.7.6-final-0 -----------
Name                         Stmts   Miss  Cover
------------------------------------------------
mech/__init__.py                 3      0   100%
mech/__main__.py                13     13     0%
mech/command.py                 52     30    42%
mech/compat.py                  29     10    66%
mech/conftest.py                30      0   100%
mech/mech.py                   532     15    97%
mech/test_mech.py              872      0   100%
mech/test_mech_box.py           84      0   100%
mech/test_mech_int.py           26     16    38%
mech/test_mech_snapshot.py     152      0   100%
mech/test_utils.py             243      0   100%
mech/utils.py                  466    142    70%
mech/vmrun.py                  240    120    50%
------------------------------------------------
TOTAL                         2742    346    87%

================================================== 118 passed in 1.81s ==