search

mechmocha / google-breakpad

Automatically exported from code.google.com/p/google-breakpad
0 stars 0 forks source link

bool BasicSourceLineResolver::Module::LoadMapFromMemory Should report buffer null error. #578

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Unsure at the moment, but this is more of a failure to show that something 
went wrong in breakpad's source line resolver which had me scratching my head 
for a while

What is the expected output? What do you see instead?

Its not so much what I see, but what I don't, as 

bool BasicSourceLineResolver::Module::LoadMapFromMemory

Seems to always want to return true even if it fails, and it fails to check if 
the buffer is null and report that at all which had me scratching my head for a 
while.

Original issue reported on code.google.com by Ghla...@gmail.com on 8 Apr 2014 at 2:12

Attachments:

GoogleCodeExporter commented 9 years ago 
As additional info, I found out this occurs with a symbol file that has invalid 
encoding (In this case UCS-2) which causes it to read 0 bytes and then it has 
nothing to parse but breakpad fails to warn you or notify you, so this would 
still be pretty useful to have.

Original comment by Ghla...@gmail.com on 9 Apr 2014 at 3:28

GoogleCodeExporter commented 9 years ago 
Can you sign the Google Contributor License Agreement and upload the patch to 
breakpad.appspot.com for review? Bonus points if you can add a test for your 
failure case to basic_source_line_resolver_unittest.cc.

Original comment by thestig@chromium.org on 9 Apr 2014 at 10:28

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
I'll get on that later this week.

Original comment by Ghla...@gmail.com on 9 Apr 2014 at 10:33