FIX: allow for print_level greater than 1 and ENH: allow warm start for dual variables

[zhengzl18]

fix #234 and #151

[moorepants]

Can you please add unit tests for these changes? Thanks for the contribution.

[zhengzl18]

Can you please add unit tests for these changes? Thanks for the contribution.

Sorry, I don't quite know how to add unit test. I just tested them with my own codes. Should I add some test script or something?

[moorepants]

We try to add a unit test, for example see https://github.com/mechmotum/cyipopt/blob/master/cyipopt/tests/unit/test_ipopt_funcs.py, to test any new additions/changes.

[zhengzl18]

That's weird. The checks seemed to fail because of the missing of SciPy. I don't understand what's going on. I've run $ pytest and passed all checks locally.

[moorepants]

Please merge in the tip of master to get the latest fixes for some scipy tests.

[zhengzl18]

Please merge in the tip of master to get the latest fixes for some scipy tests.

It seems that all the tests I added in test_dual_warm_start.py should be skipped because they were all built upon minimize_ipopt() which involves SciPy. This somehow makes these tests meaningless. Am I right?

[moorepants]

We use the pytest skip decorator to skip the tests if scipy is not installed:

https://github.com/mechmotum/cyipopt/blob/master/cyipopt/tests/unit/test_scipy_optional.py#L23C2-L24C69

[zhengzl18]

Yeah I know. I mean, since all the tests I added are based on SciPy, skipping the scipy tests would make all these tests meaningless.

[moorepants]

They are not meaningless because we run them all here in the CI system and anyone that has scipy installed and runs the tests will also run them.

[zhengzl18]

Got it. Thanks for explanation.