mechmotum / cyipopt

Cython interface for the interior point optimzer IPOPT
Eclipse Public License 2.0
227 stars 54 forks source link

Add examples/ and docs/requirements.txt to source distribution #242

Closed musicinmybrain closed 9 months ago

musicinmybrain commented 9 months ago

https://github.com/mechmotum/cyipopt/issues/237#issuecomment-1826793291

This PR seems to be effective for python3 setup.py sdist but not for python3 -m build.

moorepants commented 9 months ago

This may be better:

include setup.py
include AUTHORS
include LICENSE
include CHANGELOG.rst
include README.rst
recursive-include cyipopt *.py *.pyx *.pxd
recursive-include ipopt *.py
recursive-include tests *.py
recursive-include docs Makefile *.bat *.rst *.py requirements.txt
recursive-include examples *.py
exclude cyipopt/tests/unit/test_scipy_ipopt_from_scipy.py
prune include*
prune lib*
musicinmybrain commented 9 months ago

You’re absolutely right that I was misusing recursive-include. Thanks.

Also, I typo’ed .txt.

I’ve force-pushed a new pair of commits that makes much more sense, and which appear to work correctly with both python3 setup.py sdist and python3 -m build.

moorepants commented 9 months ago

I'm good with this. Thanks!