mechmotum / symbrim

A Modular and Extensible Open-Source Framework for Creating Symbolic Bicycle-Rider Models
https://mechmotum.github.io/symbrim/
Creative Commons Zero v1.0 Universal
10 stars 3 forks source link

RiderLean model #90

Open tjstienstra opened 1 year ago

tjstienstra commented 1 year ago

Saw that I left in a bit of a random probably deprecated model. The model is in src/brim/rider/rider_lean.py and the accompanying connection in src/brim/rider/connections.py. The idea once was to have the option to extend a bicycle with a simple leaning rider model. However, I'm not sure whether that is still necessary as one can just choose to only specify the pelvis and choose the correct values. Also the model seems to be a bit old (from before the implementation of load groups). There are two options:

  1. Keep it and update it, removing the not support actuator property. It will probably just work.
  2. Remove it and force users to the more advanced Rider model.