Closed MaximeHollebecq closed 4 years ago
Should I review the code ?
@QuentinDaveau yes please, have @MaximeHollebecq walk you through it and provide some feedback. That would be great, thanks! 🌴
The commits and code seem all good to me, it's Quentin's approuved :D! We spotted a small issue with the data logging however, but it is out of context of this pull request. Maxime should create an issue for it.
This pull request is created to solve the issue #3 , the different scene were reworked to fit with the mockup in the issue except the connecting + error handling screen because the database connection status are displayed on the main screen.
After entering your credential (Email , arduino COM port , baudrate) , you can click on the connect button. an error message will be displayed if the COM port/Email is wrong.
when the credentials are correct , you are redirected to the main scene where you can click on the start button to start the logging and enable the display
when you want to stop the logging , you have to press the stop button , an explorer panel will appear which make you choose the destination of the csv files that contain the data
if needed , a restart logging button is available in case you want to restart the process