Handle Arduino disconnection

[Vincent-SD]

Main changes

• Notify user if the Arduino board is disconnected in data logging page
• Deactivation of the button to launch the logging if the Arduino board is disconnected
• Add a button in data logging page to return to the previous page
• Add a button in the Arduino connection page to refresh the port detection

Closes #5

[bastianilso]

Hi Vincent, thanks for working on this issue. There are a lot of good things in here, and then a few things where we some design iteration. So before i give you feedback on code, lets talk design.

Design:

• Back button: we need a better icon, preferably this arrow icon. Save this as Assets/ConnectToArduino/arrow-back.png .Let's also use a more descriptive label, e.g. "Reconnect".
• We should align your disconnect label with the existing style used in the Arduino Logger, see the mockups below:
• In addition, the title will need to change and we need to jump into a state where we interrupt the arduino and allow the user to save the data.
  • Rather than a refresh button on the connection page, how about automatically refresh the port list every 5 seconds in the background?

Commits: Your work here can conceptually be divided into solving several problems. Please separate your work into commits which each address their own problem. This way code is easier to read and in case we need to trace back to a regression in the code later, its easy to see which commits are related to the problem. Here is how I would structure your commits:

• Refreshing the port list of the Arduino.
• Allowing the user to go back to the previous page.
• Show Arduino status next to the Arduino Output.
• Interrupt the Arduino if the Arduino disconnects and allow the user to save the work.

[bastianilso]

Thanks for the final changes Vincent. I had a quick look in Unity and the visual changes looks good to me.

I hope that our revision process helped you to structure your commits and make them well defined. I look forward to reviewing your future pull requests. In the future, I also want you to pay attention to:

• Make sure all changes are related to what the commit is trying to fix/solve.
• Remove newlines, "code styles changes" and other minor changes which create noise - feel free to put these in a separate commit. Many Code Editors (e.g. Visual Studio Code) will highlight the changed lines with green (addition) or red (removal) to help you.
• Review how your commits look like using e.g. git log -p so that you can see how they will appear for your reviewers.