Infrastructure: Upgrade SteamVR

bastianilso commented 2 years ago

As part of resolving issue #183 we need to upgrade our version of SteamVR. This process involves several steps.

We need to see what version of SteamVR we are currently using.
We need to identify which version of SteamVR is the next to upgrade to, given that we are still on Unity 2019.x. (See all releases here: https://github.com/ValveSoftware/steamvr_unity_plugin/releases)
There will most likely be API changes that we need to follow, in order to make Whack-A-Mole VR work again - related to controller bindings.

First step in this issue is to research it and see what is possible. @lucasmnt please let me know what you might find. I have assigned you to this task, but if @Xav1204 would rather want to work on it, feel free to swop. 🙂

bastianilso commented 1 year ago

@lucasmnt @Xav1204 if one of you have time this week, I would like you to start a branch where you investigate this. Please inform in this issue what discoveries you make about it.

Xav1204 commented 1 year ago

@bastianilso Is it normal that we don't have steamVR plugin in the package manager?

Xav1204 commented 1 year ago

@bastianilso It's good, I found the version in the following file : "\Assets\SteamVR\readme.txt".

We are actually in the version 2.0.1

bastianilso commented 1 year ago

@Xav1204 older versions of SteamVR are not provided through the Unity Package Manager. OK, so now that we know which version we are at, next we need to know which version we can upgrade to, while staying on Unity 2019.x.

You can download find unity packages of all steam vr versions from the link I provided: https://github.com/ValveSoftware/steamvr_unity_plugin/releases

Hope that helps.

Xav1204 commented 1 year ago

For the second question, we can upgrade our steamVR version until the lastest one that is the 2.7.1. In the documentation, it's write that a package will be installed. Therefore, as the package that we need is installed so we won't encounter a problem with this. However, I don't know what will happen with Unity XR as we are under v2020.

For the third question, yes we will have some changes to make in order to make that the game work again.

I will try on a new branch to make this changes and I will tell you if I encounter any problems during the process.

bastianilso commented 1 year ago

@Xav1204 fine, just make sure we stay on the current Unity 2019.x version in your experiments. Otherwise too many things are changing at once, and it will be difficult to debug possible regressions. So if 2.7.1 requires upgrading Unity, it's better if we start by trying an older version of SteamVR first - because there will be API changes, that requires changes to the Whack-A-Mole code.

Xav1204 commented 1 year ago

@bastianilso I succeeded to update steamVR until its latest version. I just need to try with the VR headset if the controllers are still working. Moreover, I didn't change Unity Version.

bastianilso commented 1 year ago

@Xav1204 cool.feel free to borrow the VR headset on my desk for some preliminary testing.

bastianilso commented 1 year ago

Todo for the SteamVR:

Document the errors you get and how you solved them.
If the above does not work as expected, try creating a new empty project with Unity 2019.3.13f1 and import the SteamVR unity package. Confirm whether it works without Whack-A-Mole VR components first. Try to replicate one-by-one the CameraRig used in Whack-A-MoleVR. You can try to import the default CameraRig which we know works and go from there.

Xav1204 commented 1 year ago

@bastianilso it's better now, we see the controller, the cursor input and movement are correct and we don't have problem with the camera direction. I just need to investigate why the hand and the blue circle don't appear.

Xav1204 commented 1 year ago

@bastianilso you will find attached the report about the steamVR upgrade.

steamVR.pdf

bastianilso commented 1 year ago

@Xav1204 i think the SteamVR upgrade might be the next step to upgrade, what do you think? Feel free to create a pull request.

Xav1204 commented 1 year ago

@bastianilso yes, upgrade SteamVr is the next step to do in the different upgrades that we need to do. As soon as I will finish the prism effect, I will do this issue.

Xav1204 commented 1 year ago

@bastianilso I've found the problem with the hand/controller position and rendering. I will write you a report to explain what I've done to solve the problem. We can so upgrade SteamVR to the latest version.

Xav1204 commented 1 year ago

@bastianilso Here the report about the problem that we had with the hand position and rendering : steamVR.pdf

med-material / Whack_A_Mole_VR

Infrastructure: Upgrade SteamVR #197