Closed Xav1204 closed 1 year ago
little English feedback: the correct/right position. "The good position" is not a thing. 👍
@bastianilso it's good, I made the changes.
@bastianilso tell me if it's good for you.
@Xav1204 for these kind of visual changes, it would be easier if you made a screenshot of your changes. 🙂 Here I did it for you:
For reference, this is the design wire:
As is clear from the comparison, the position of the left image and the size of the text to the right are not matching the design wire. I can also see that the text needs to be updated in the implementation (to the new text shown in the image). You seem to have fairly good grasp of the Unity UI system already, but I would like you to aim for higher precision with regards to matching how text and images are laid out on the wire. Thanks! 👍
OK so the current commit looks like this: (@Xav1204 please upload screenshots when you update your pull request, so I can follow along - I dont know otherwise whether you are awaiting a review from me. 🙂 )
We concluded that it might be better to make it smaller because the current instructions are approaching the "blurry zone" of VR. @Xav1204 let me know when you have an update. thanks!
We have now this instruction panel. in the VR headset, we have always the 'blurry zone' but the letters are readable.
@bastianilso it's good, I finished the new panel and I also added the fadeOut effect.
Think about your smartphone, for example. When you unlock the screen, how fast that animation actually is? It's usually around 400-600ms, sometimes even faster. This is the kind of speed we are targeting. 🙂
@bastianilso I think that it's good now.
@bastianilso it's good. I put the transition speed by default at 3.
@bastianilso just a little change. Transition speed variable looks like the time of the transition. I just changed the variable name in ratio speed, it's more understandable.
We needed to update the instruction panel to show to the patient what is the good position to have in order to play the game. So the instruction panel is now updating but we also need to make a fade out to the calibration panel. However, we will wait the fade In/Out script manager before doing this.