Closed Xav1204 closed 1 year ago
I made a gif to show the animation but it was too heavy so I compressed it.
great. For future submissions try to e.g. reduce the resolution because the steps of downloading and unzipping defeat the purpose of having a visual here for easy browsing. :-)
I did it again. I think that it will be better now.
Hi @Xav1204, can you try speeding it up by 2x (double speed)? Just want to see how it looks, compared to current animation you uploaded. thanks!
@bastianilso Is it enough fast for you?
@bastianilso I pushed the updates. I also commented the code with the explanations of my choices.
@Xav1204 Could you please respond directly to my questions in the pull request itself?
I think it's fine with the code comments too. By convention we either use code comments if a) we want to document what a function does, or b) if we introduce a hack/do something unconventional/do a workaround of some kind.
@bastianilso I didn't see any questions in your last comment. Do you want that I respond to the question about the interest of the Chunked Lists?
@bastianilso it's also good for the mole spawn animation. We just need to see the behavior of the animation after having solved the conflicts
We needed to add a small animation on the wall to make the experience more immersive. Now, the mole spawn randomly on the wall surface.
What we still need to do: - Add a fadeout transition for the countdown panel