search

med-material / Whack_A_Mole_VR

Whack-A-Mole in VR
MIT License
3 stars 15 forks source link

Logging: MoleType column is not always in dataset #212

Closed bastianilso closed 1 year ago

bastianilso commented 1 year ago

In commit 57961dbfd1404ab77748757fa2de8576eaa5a328 we introduced logging of MoleType in Mole.cs logging, so that we knew whether the mole was facing right or left, but it seems like this information doesn't always appear in the dataset.

We need to verify if the issue replicatable and what causes it.

Xav1204 commented 1 year ago

image

@bastianilso this issue is solved?

bastianilso commented 1 year ago

@Xav1204 no, it's the column called MoleType, created here:

https://github.com/med-material/Whack_A_Mole_VR/blob/master/Assets/Scripts/Moles/Mole.cs#L290

I implemented the moletype name as part of the logged event, as a workaround but it doesn't solve the issue that there is no separate column called MoleType in the event dataset.

Xav1204 commented 1 year ago

image @bastianilso I have this now, I don't know if it's that you really want. Please tell me if it's right for you.

bastianilso commented 1 year ago

@Xav1204 yes, the point is to have the MoleType column in the logging dataset. Note, that this is not about writing code such that it appears, the point is to investigate why the MoleType column doesn't appear, so we can arrive at some possible technical explanation (bug in LoggerNotifier? Mole.cs code is never called? etc). You can report here what you try and what you find out. 🙂👍

bastianilso commented 1 year ago

fixed with commit 610bc1