med-material / Whack_A_Mole_VR

Whack-A-Mole in VR
MIT License
3 stars 15 forks source link

WallManager: Log position of each mole on creation time #235

Closed bastianilso closed 1 year ago

bastianilso commented 1 year ago

Currently WallManager logs its extremities and each mole logs its position whenever it is interacted with. This is fine if all moles are interacted with or if the moles are vertically/horizontally aligned. However, any of these assumptions may break if some moles dont activate during the game or if we later apply some jitter/random noise to the mole's locations (which is a feature which has been requested in issue #171). Visualization tools which rely on visualizing positions of all moles on the wall therefore cannot be certain about unactivated mole's locations.

To address this issue, it might be most future-proof if for each mole, the WallManager on Wall Generation reports to LoggingManager a Mole Created event, along with the mole's MoleIndexX/Y and MoleWorldPositionX/Y/Z.

Xav1204 commented 1 year ago

@bastianilso The informations of each moles need to log in a specific csv file ?

Xav1204 commented 1 year ago

log_2022_11_29_10_47_39_3266_Event.csv

@bastianilso I have saved the information in the event csv file for the moment. Can you tell me if this is the result you were expecting?

bastianilso commented 1 year ago

@Xav1204 yes, this is what I was expecting.

Xav1204 commented 1 year ago

@bastianilso great. For this issue, we have two options.

  1. We can use a reference to loggingManager in wallManager.
  2. We can use an UnityEvent to send mole Information from wallManager to loggingManager.

Which option do you want to implement ?

bastianilso commented 1 year ago

resolved with merge of #236