med-material / Whack_A_Mole_VR

Whack-A-Mole in VR
MIT License
3 stars 16 forks source link

Fix Bug and add one event in Event.csv #247

Closed Xav1204 closed 1 year ago

Xav1204 commented 1 year ago

@bastianilso For this pull request. The first thing that I've made is to add the event " Controller Main Set + controllerName" in Event.csv. To do this, I've created a function in modifiersManager to log the event in event.csv and I call it in gameDirector after having log "Game Started" because it made sense to log what controller we use after having log "Game started". image

The second thing that I've made is to add in Event.csv and Sample.csv the columns ControllerLeftLaser. So I've changed the code because to store the logTracker component in the list, we used a specific function that search the component on the scene but the problem was that if the parent object is disabled, the function won't find the component. I've changed the inheritance of TrackerHub on Monobehaviour to add it on EventLogger Object : image In this script, we now add the object directly in the list for not having problem. As the two others scripts are a component of EventLogger, we just get the component directly on the parent.

Let me know if something can be improved.

bastianilso commented 1 year ago

A modified version of this branch was rebased to master via commit 11924a120d637124de46354dba577c29faaa0638