Working outline - Githubissues

med-material / d3-rshiny-vis

Example project of making D3.js visualizations within R shiny

MIT License

0 stars 0 forks source link

Closed Xelkyo closed 1 year ago

Xelkyo commented 1 year ago

We have a vizualisation of the eyes tracking (average of both eyes) with an outline.

bastianilso commented 1 year ago

Hi @Xelkyo, your pull request current points from Eyes_Tracking_Interactivity into Eyes_Tracking. But I would have expected your pull request to point into main.

Xelkyo commented 1 year ago

Oh okay I thought you would like to review the code before putting it in Eyes_Tracking.

bastianilso commented 1 year ago

@Xelkyo what I meant was:

we use the main branch for all reviewed/approved code (so currently it is empty).
we use the Eyes_Tracking branch for the current static version you have finished. We will now review/approve this work to go to main.
while you wait for that, you can then use Eyes_Tracking_Interactivity to work on the interactive stuff we discussed as the next step for this visualization.

hope that makes sense. 🙂