Open bastianilso opened 2 years ago
Regarding filter buttons (Patient, Outpatients...) :
Does the data change also apply to "Training Programs" ? Or the part "training Programs" only takes into account the dataset with all the sql data ?
I ask this question because the fact that the buttons are in the part "demographics" doesn't make sense to me (if the change also applies to "Training Programs")...
If the buttons apply to both sections, would you prefer to move the filter buttons above the title "demographics" ? this shows that the buttons are not only useful in a section but well on the whole page
Hi Jules, that's a good point - in fact, maybe these categories can apply onto the whole page. What do you think?
In that case, we should definitely move the button toolbar to the very top of the page, rather than under the "Demographics" headline. It should also apply to the aggregate numbers.
I think it would be a good idea to apply the changes to both sections. On the other hand, I don't know if it really has an interest to apply the modifications on the aggregate numbers 🤔
What do you think of this dashboard ? Do you have any suggestions ?
Looks good Jules, functionality-wise, this dashboard is covering most of what we want to see. What we need to do here next, will be a visual overhaul, the dashboard feels more balanced. Check this quick mockup below:
Hi bastian,
About the filter buttons (Filter players and filter game type), what are the default values ?
Hi Jules,
Filter players: Only stroke patients + outpatients Filter game type: Both
Hi Bastian, about the timeline, The graph currently looks like this. do you have any advice or things you want to change ? For example, do you want to display the players having only one point (ie having only played on one date).
Hi Jules, excellent, very cool. 🍹 I think we want a slider underneath, which provide easy horizontal zooming of the data. see a reference implementation here: https://plotly.com/r/range-slider/
Also, is each line a player or is each line a "player-gametype" (e.g. if someone played both modes, do they display as 1 or 2 lines?) I think the expected behavior we want, is that each line = a player.
EDIT: also how well does the graph work, if you activate all players?
I will implement it immediately ! Each line corresponds to a player (so 1 line by player in every case) 🦭.
is that what you expected?
Yes. I wonder what options do we have for customizing it? Couls you check?
I can change the height (thickness). I can change the style (for example the background color) I can change the y axis range (for example if you want the rangeslider to display only the first 10 players)
I think I've summarized the documentation for rangeslider.
Thanks jules, this was the link I was looking for. Can you apply a 1px black border around it (or same pixel width as the plot uses for x/y-axis). Is 'type' set to 'date' ?
EDIT: Also, you are welcome to highlight the current chosen player with orange.
Yes the 'type' is set to 'date'. Does it suit you? 🦖
perfect, thanks jules! I will keep the issue open, just in case we add more items to it in the future.