Assignment2 vibrato - Githubissues

med1844 / 2022-MUSI6106

Template project for assignments and exercises for the class MUSI6106

GNU General Public License v3.0

0 stars 0 forks source link

Assignment2 vibrato #3

Open RoseQSun opened 2 years ago

johnnymac647 commented 2 years ago

I could not build the project immediately on my machine (macOS Monterey 12.2.1), so most of my comments are addressing the errors I'm receiving on my end.

I don't think your Vibrato and LFO parameter enums need to have the "class" keyword.
It looks like passing a string argument to the std::exception constructor is only possible via an extension in Visual Studio (see https://stackoverflow.com/questions/28640553/exception-class-with-a-char-constructor).

med1844 commented 2 years ago

Good job!

Many files are unnecessary to be included in the repo. I find Github Desktop is helpful to ignore these files.

I'm pretty sure the files you are complaining about are the google test source files in 3rd party, which is inevitable. Despite these there's no unnecessary files. We have carefully modified .gitignore to avoid intermediate build files, and you might want to take a look into that.