search

medInria / medInria-public

Open-source part of the medInria software
https://med.inria.fr/
BSD 4-Clause "Original" or "Old" License
92 stars 72 forks source link

Refactoring for Python packaging - med3.4 #1198

Closed mathildemerle closed 7 months ago

mathildemerle commented 9 months ago

Cherry-pick from PR https://github.com/Inria-Asclepios/medInria-public/pull/810

uses https://github.com/LIRYC-IHU/pyncpp/pull/16 and https://github.com/Inria-Asclepios/music/pull/1045 This PR introduces various changes to fix the Python packaging and also allow compilation on github actions:

  • switch to _ROOT instead of _DIR
  • improve external project code so that USESYSTEM(project) works correctly even for non-cmake projects
  • improve handling of music-specific dependencies (eigen, mmg etc.) to work with _ROOT paths
  • improve handling of python plugins
  • install external projects manually during packaging on Linux instead of using cpack mecanism that does unecessary recompilations
  • add USE_MUSIC_PLUGINS option
  • patch ITK for Visual Studio 2019
fcollot commented 7 months ago

@mathildemerle we can close this PR as I am merging the changes in separate PRs