The current implementation of the ep_Initialisation has two issues:
It does not correctly implement arguments. The argument names (such as USE_SYSTEM) should not be part of the signature.
The macro expects external projects to be cmake packages that are searchable through find_package.
The macro expects the package name to be the same as the external project name.
This PR correctly implements the arguments and adds PACKAGE_NAME to specify alternative package names and NO_CMAKE_PACKAGE to allow non cmake external projects to be added. (Note that USE_SYSTEM, BUILD_SHARED_LIBS and REQUIRED_FOR_PLUGINS should in practice be options, not single-value arguments, but I preferred keeping the macro compatible with the current code)
_(also the NO_CMAKE_BUILDS_PATH option to find_package is removed because it is no longer used by cmake)_
The current implementation of the
ep_Initialisation
has two issues:USE_SYSTEM
) should not be part of the signature.find_package
.This PR correctly implements the arguments and adds
PACKAGE_NAME
to specify alternative package names andNO_CMAKE_PACKAGE
to allow non cmake external projects to be added. (Note thatUSE_SYSTEM
,BUILD_SHARED_LIBS
andREQUIRED_FOR_PLUGINS
should in practice be options, not single-value arguments, but I preferred keeping the macro compatible with the current code)_(also the
NO_CMAKE_BUILDS_PATH
option tofind_package
is removed because it is no longer used by cmake)_