Tests (update please as we go)

[mikejbuckingham]

So as requested, can we get people to test the following:

medInria compiles on Windows, Linux and MacOS medInria correctly loads all plugins

All medInria filters work as expected: Add Divide Gaussian Invert Multiply Median Normalize Subtract Windowing

Visualiation works as expected (2d, 3d) on all OSes and both Intel and nVidia chipsets Visualisation performance has not significantly degraded from VTK5 (medInria 2.2.1)

Composer provides full functionality Presenter vs Port for parameters correctly values Port over Presenter All nodes have the correct ports and presenters Compositions work as expected, end-to-end

Please also play around with the app and report all crashes, weird behaviours, etc.

[ocommowi]

Hey, I had been playing around with a previous version and noted quite a few bugs in issue #261 . Could you merge those two issues (and may be tick what you have finished, I believe there are many) ? Thanks and great job by the way !

[ocommowi]

First list of bugs from my side (moved from #261)

• [x] Paint segmentation interaction is not rendered: the painting is done but the view doesn't render itself to show it
• [x] closing the last view of a tab leaves it in an awkward situation: not going back to base mode of the tab, just leaving it empty and not closable
• [x] Going to the finder in browser on Mac makes the app crash
• [x] dropping a tensor image (or any glyph based image) in an empty view generates a lot of warnings in the console. This seems to happen only when the image voxel size is not 1 though
• [x] Diffusion tractography fails when a tensor is negative (TTK related, I'll handle it)
• [x] Regression in diffusion workspace: in diffusion estimation, we cannot anymore do a brain masking plus model estimation. This would require an abstraction on its own, not sure yet how to handle this
• [x] Switch to four views leads to unequal splitting of the container in 4 parts (eg use the I1 image in medinria-data registration). In a more general way, spliiting is somewhat broken, sometimes the size equalizer button doesn't work, sometimes dropping an image inside an empty view makes it bigger, ...
• [x] Some view interaction glitches: for example drop the 4d image of the heart, then the heart mesh. If you interact with the view, it will change the window level of the first layer (image) even though the mesh is selected on the right. In addition if that view is linked to others (eg do a 4 view split after dropping the two data), then this window leveling is not synchronized with the others
• [ ] Remaining bug from previous: drop the 4d image of the heart, then the heart mesh. If you interact with the view, it will change the window level of the first layer (image) even though the mesh is selected on the right. That bug was already there in medinria 2 though
• [x] Drop the 4d heart image, switch to 3d mode, click on play in the navigator -> the image doesn't move. It does work in 2d but not 3d anymore...
• [x] A new one on visualisation: not sure if it is due to vtk or us, view a set of fibers in 3d has a problem of transparency when you rotate around the fibers

[mikejbuckingham]

• [x] saving a loaded file to database makes its thumbnail disappear (written in the right folder but not found later on)
• [x] the composer does not appear in bottom left menu and neither in all places where areas and workspaces are listed
• [ ] Composer stylesheet to update
• [x] Ctrl + Space menu missing icon for generic workspace, composer missing as well
• [x] home page : clinical category is empty, other as well if no generic workspace (remove them dynamically if empty ?)
• [x] stylesheet of combo box is wrong (eg selecting a plugin), probably some others as well
• [x] Missing labels for parameters in filtering (probably diffusion as well) toolboxes, "change me" tooltips for many of them
• [x] We've lost the about plugins buttons. We should put them back
• [x] Generic, filtering and diffusion workspaces probably do something wrong when loading plugin processes or handling them: when quitting the app after using one plugin in those workspaces, there is a crash

[ocommowi]

A few more bugs for those who would be looking for stuff to do :)

• [x] Multi-layering ugly bug: drop an image, and another one in overlay, then remove the top layer in the layer settings toolbox. You get the only layer left having a transparency over it (image almost not visible)
• [x] Switching sample rate of glyphs visualization (ODF, tensors) makes them disappear of the view
• [x] Changing the window level on an axial view doesn't change it in the 3D MSR view
• [x] Quitting by Cmd+Q (Alt+F4 on win) doesn't ask for saving non persistent datasets
• [x] If visu workspace selected as default in settings, going to segmentation when opening the app or even crashing in some cases
• [x] There is no way to resize views manually anymore
• [x] When maximizing a view, you have to click on the view again for the snapshot shortcut to work, otherwise it doesn't do anything
• [ ] Some of the shortcuts listed here https://med.inria.fr/docs/51-doc-shortcuts do not work anymore. The regression has happened before the dev branch (Ctrl + (Shift + ) Tab : Go to next (previous) tab / Ctrl (Cmd) + 1,2,3 or 4 : Switch between Axial, Coronal, Sagittal, 3D view)
• [x] Screenshot capture is not working anymore. You get empty views, probably something related to us using gvtkgraphicsitem now
• [x] Sometimes a crash happens when quitting medinria related to views and tabbed views deletion. Replicating this will do it : open medinria, load a first layer with an image, then add a mesh on top of it. Now close the app and the crash happens

[LoicCadour]

• [x] Once you've seen your data in VR, changing the orientation is quite slow, slicing is very slow. It's also happened to me since I am using VTK7 in MUSIC.

[Florent2305]

• [x] Remove deprecated VTK VR modes
• [x] Add new VTK VR modes if they are available
• [x] In 4D volume, in visualization mode, when time is set manually, if you press 'play' button, it start playing at the first 3D volume.

[Florent2305]

• [ ] Check memory leaks.
• [ ] Check memory over consuming (free memory too late, not just in time).
• [ ] Remove old test suite.
• [ ] Re implement a valid test suite.
• [ ] Pretty print all code with the same policy.
• [ ] In header files put the "#pragma once" on the first line, befor any comments or licence comment.
• [x] Remove multiple and different log system and use an unique one.
• [ ] Remove export macro into internals class of plugins.
• [ ] Simplify all visualization plugins because they are over ingegerd after separation of some class from medVtkInria .
• [ ] Define clearly APIs of vizu plugins, internal modules, etc. And document its well with doxygen.
• [ ] On MS-Windows fix problem of static/dynamic libs.
• [ ] On MS-Windows fix problem of mixing debug for medInria and release for frameworks (VTK, ITK, ...). For the moment it ignor release mode for frameworks if medInria use release compilation mode.

[alegouhy]

• [ ] proposition: add feature to select fiducial points

[ocommowi]

Two new view bugs following our modifications:

• [x] Double clicking somewhere on a view does not move the axes anymore (neither the linked ones)
• [x] 4D views time changing is wrong (compared to medinria 2 which works fine)

[Florent2305]

Too old. I closed it