medajet / pe

0 stars 0 forks source link

addapplicant does not allow s/o #14

Open medajet opened 2 years ago

medajet commented 2 years ago

Some names contain s/o, and the command does not allow adding of such names.

image.png

soc-se-bot commented 2 years ago

Team's Response

Duplicate of #2027

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

special character / is not allowed in name field.

When inputting legitimate name such as Nagaratnam s/o Suppiah, the GUI warns about invalid input

image.png


[original: nus-cs2103-AY2122S2/pe-interim#2014] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

As our application is for recruiters to track their own list of applicants and jobs, they can just put "so" or "son of", and make a mental note to replace it with "s/o" when they need to.

Also, Some individuals may omit the patronymic phrase altogether and write their name simply as [given name] [father’s given name]. This can lead foreigners to mistake the father’s given name for a family name. https://culturalatlas.sbs.com.au/singaporean-culture/singaporean-culture-naming

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: This should be counted as a bug.

Relevant section from textbook:

image.png

Taking into consideration that it is critical for job application information to be as accurate as possible (as companies are often subject to checks by governmental bodies), a person using the application should be able to input information exactly as the job applicant states without having to resort to making a mental note. In addition, it is possible for multiple users to use the program, considering that a company's HR department will likely have multiple employees anyway.

Regarding severity, I feel that it should be Medium. While a case can be made for less critical applications such as a basic phonebook, this application is meant for tracking the legal details of a person, including their NRIC. Information should be inputted accurately, and making concessions such as resorting to using "so" instead of "s/o" can lead to undue confusion, especially when someone needs to refer to the app to fill in the applicant's details elsewhere.


:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: This should be counted as a bug.

Relevant section from textbook:

image.png

Taking into consideration that it is critical for job application information to be as accurate as possible (as companies are often subject to checks by governmental bodies), a person using the application should be able to input information exactly as the job applicant states without having to resort to making a mental note. In addition, it is possible for multiple users to use the program, considering that a company's HR department will likely have multiple employees anyway.

Regarding severity, I feel that it should be Medium. While a case can be made for less critical applications such as a basic phonebook, this application is meant for tracking the legal details of a person, including their NRIC. Information should be inputted accurately, and making concessions such as resorting to using "so" instead of "s/o" can lead to undue confusion, especially when someone needs to refer to the app to fill in the applicant's details elsewhere.