search

medajet / pe

0 stars 0 forks source link

Phone numbers should not be fixed at 8 digits #4

Open medajet opened 2 years ago

medajet commented 2 years ago

As it is possible for applicants to have foreign phone numbers, an input validation for the phone number to be fixed at 8 digits can be considered overzealous.

image.png

nus-se-script commented 2 years ago

Team's Response

Duplicate of #1934

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Overzealous phone input validation

There could be situations where phone numbers do not start with 6, 8 or 9 or longer than 8 digits.

image.png

[original: nus-cs2103-AY2122S2/pe-interim#1949] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

No details provided by team.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: Considering that it is increasingly common for there to be cross-country workers especially in Singapore, (e.g. Malaysia), the current implementation of input validation means that if the person does not have a local number, there will be no way for the user to add their number to the database. Going by the classification of severity:

image.png

I believe that the bug fits the classification of Medium, since the user can indeed continue to use the product, but any situation where the above occurs means that the user will have no way to store the phone number in the app.

Furthermore, the product's target market does not seem to be scoped to Singapore (no mention in UG/DG), so the bug means that the product is almost unusable elsewhere.