search

medblocks / medblocks-ui

Web Components Library for Medblocks Ecosystem
https://www.npmjs.com/package/medblocks-ui
Apache License 2.0
54 stars 15 forks source link

Performance issue when destroying components #17

Closed sidharthramesh closed 3 years ago

sidharthramesh commented 3 years ago

There are multiple onDestroy events happening during tear down, and most of them are unnecessary since the whole component is going to be destroyed anyway. Once the onDestroy signal is received, setting a flag to not do anything on the child components and execute clean up on the composition can speed up things significantly.

sidharthramesh commented 3 years ago

It's because of the transition on a fucking button. Closing.